Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message for 'ResourceShaclEngineRejection' #4862

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

imsdu
Copy link
Contributor

@imsdu imsdu commented Apr 10, 2024

Fixes #4830

In the end, the problem was not related to a resource not found but to a static remote context (the shacl one provided by Nexus) required to generate the compacted representation of the validation report.
In the end, the problem happened because the import batch did not inject this static context so this PR is:

  • Enriching the error message to make it clearer
  • Giving it a 5xx status as it is a problem of the application

Copy link
Contributor

@shinyhappydan shinyhappydan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the resource isn't found shouldn't we end up with a 404? Feels like we could split the error into two: a shacl engine error and a resource not found

@imsdu
Copy link
Contributor Author

imsdu commented Apr 10, 2024

If the resource isn't found shouldn't we end up with a 404? Feels like we could split the error into two: a shacl engine error and a resource not found

Sorry, I should have made it clearer on what was the solution. I edited the description of this PR.

@imsdu imsdu merged commit 3780d5f into BlueBrain:master Apr 11, 2024
6 checks passed
@imsdu imsdu deleted the 4830-improve-shaclenginerejection branch April 11, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better handling of ResourceShaclEngineRejection
3 participants