Patch distributions in import batch #4880
Conversation
| @@ -0,0 +1,7 @@ | |||
| CREATE TABLE IF NOT EXISTS public.ship_original_project_context( | |||
There was a problem hiding this comment.
To save the original project context to expand selfs when needed
| * Allows to keep track of the original project context which will change because of project renaming / patching | ||
| * configuration so as to be able to use them to expand iris in resource payload | ||
| */ | ||
| class OriginalProjectContext(xas: Transactors) extends FetchContext { |
There was a problem hiding this comment.
You don't need to implement FetchContext for this?
There was a problem hiding this comment.
The only place it's needed is in FileSelf, so you could just split the interface. I think it's likely that a lot of places it would make sense to just pass onRead rather than all of these methods
There was a problem hiding this comment.
Most of the methods come from FetchContext and the import batch is a special use case, if we are to refactor it, it is outside the scope of this PR
| } | ||
| }(_) | ||
|
|
||
| def single: Json => IO[Json] = (json: Json) => fileContentUrl(json).map(toS3Location) |
There was a problem hiding this comment.
This method is never used in real code, the tests can easily call the other one
There was a problem hiding this comment.
It would still be more complicated as an extra level would be required
| import io.circe.syntax.EncoderOps | ||
| import io.circe.{Codec, Json} | ||
|
|
||
| /** |
There was a problem hiding this comment.
I guess this is going in postgres so we can import in multiple sessions?
There was a problem hiding this comment.
The batch will run in an incremental way so we need to keep track of those contexts in the different runs.
Is that what you are asking ?
ship/src/test/scala/ch/epfl/bluebrain/nexus/ship/resources/DistributionPatcherSuite.scala
Show resolved
Hide resolved
Fixes #4876