S3 content type user supplied #4895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinyhappydan
commented
Apr 23, 2024
.../ch/epfl/bluebrain/nexus/delta/plugins/storage/storages/operations/s3/S3FileOperations.scala
Outdated
Show resolved
Hide resolved
shinyhappydan
force-pushed
the
s3-content-type-user-supplied
branch
from
6106f74 to
26ba43b
Compare
imsdu
reviewed
Apr 24, 2024
| private def parseContentType(raw: String): IO[ContentType] = | ||
| ContentType.parse(raw).map(_.pure[IO]).getOrElse(IO.raiseError(InvalidContentType(raw))) | ||
| private def parseContentType(raw: Option[String]): IO[Option[ContentType]] = { | ||
| raw match { |
There was a problem hiding this comment.
traverse could be your friend here
imsdu
reviewed
Apr 24, 2024
|
|
||
| def baseEndpoint: Uri | ||
| } | ||
|
|
||
| object S3StorageClient { | ||
|
|
||
| case class UploadMetadata(checksum: String, fileSize: Long, location: Uri) | ||
| case class HeadObject( | ||
| fileSize: Long, | ||
| contentType: Option[String], |
There was a problem hiding this comment.
It could have directly a ContentType here
imsdu
reviewed
Apr 24, 2024
| case class HeadObject( | ||
| fileSize: Long, | ||
| contentType: Option[String], | ||
| sha256Checksum: Option[String], |
imsdu
reviewed
Apr 24, 2024
.../ch/epfl/bluebrain/nexus/delta/plugins/storage/storages/operations/s3/S3FileOperations.scala
Outdated
Show resolved
Hide resolved
shinyhappydan
force-pushed
the
s3-content-type-user-supplied
branch
from
26ba43b to
bf5af4e
Compare
|
@imsdu I addressed one comment, but currently in merge hell and not sure about the others. I don't disagree with what you're saying I'm just going to avoid dealing with it for now, because they aren't blocking us |
dantb
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4881