Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the patching strategy for contentUrl, atLocation.location and url #5249

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Changing the patching strategy for contentUrl, atLocation.location and url #5249

merged 3 commits into from
Nov 26, 2024

Conversation

imsdu
Copy link
Contributor

@imsdu imsdu commented Nov 25, 2024 •
edited
Loading

When contentUrl matches the defined prefix

  • Strip the prefix from its value
  • Apply the patched value to contentUrl, atLocation.location and url

If not. fallback to atLocation.location:

  • Strip the prefix from its value
  • Apply the patched value to atLocation.location and url

@imsdu imsdu changed the title Copy location to url Changing the patching strategy for contentUrl, atLocation.location and url Nov 25, 2024
crisely09
crisely09 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@crisely09 crisely09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@imsdu imsdu merged commit 2d6f506 into BlueBrain:master Nov 26, 2024
2 checks passed
@imsdu imsdu deleted the copy-location-to-url branch November 26, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisely09 crisely09 crisely09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imsdu @crisely09