[UPSTREAM UPDATE] 09.01.2025 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recated and will be removed in the future. In older versions of TGUI, InfernoJS did not have hooks, so these were used to manage state. useSharedState is still used in some places where uis are considered "IC" and user input is shared with all persons at the console/machine/thing.
…sing the new system (#87892) Partial revert of #86701 Implements a shared holder particle system, somewhat inspired by Baystation12/Baystation12#34014 (thanks Kapu). Atoms can be assigned "shared" particles via add_shared_particles, with an optional "alternate" key passed as a second arg if you're planning to edit the returned particle holder (for example, color it like slimed status does). Removing is done via remove_shared_particles with an option to delete the shared holder if nothing is using it anymore (on by default). This system should be prioritized over normal particle holders when a lot of entities would be using a certain particle effect (like fires) as it conserves a lot of clientside performance. Burning, acid, decaying, firestacks and slimed status now use this system which should help with clientside performance and amount of atoms created/destroyed. Less clientside lag. :cl: refactor: Firestacks, burning/acid/decaying effects and (brought back after being temporarily removed) slimed status effects now use a new "shared" particles system, which should considerably improve client performance when encountering a lot of burning/slimed entities. /:cl: --------- Co-authored-by: Ghom <[email protected]>
…#88048) ## About The Pull Request Closes #83370 Converted most cases where we could benefit from using shared particles (aka when there's probably more than 3 uses of that particle in a round) to use the new shared particle system. Should provide significant clientside performance in particle-heavy areas like botany (or sometimes kitchen) ## Changelog :cl: refactor: Converted most common particle sources to use our new pooling system. /:cl:
## About The Pull Request Caused by: - #88048 The coffee maker smoke particles stayed on forever after brewing something. This is now fixed. ## Why It's Good For The Game Coffee brewing is no longer a fire hazard. ## Changelog :cl: fix: Fix coffee maker smoke particles not deleting /:cl:
## About The Pull Request Caused by: - tgstation/tgstation#88048 Trying to use the fireplace would result in runtimes and the smoke particles not triggering. Even though the runtime is fixed, the new particle changes in #88048 broke the pixel offsets. While I was testing, anytime I tried switching a pixel offset it would update all fireplaces. I tried to limit it to add the shared particle id to `"fireplace_[dir]"` so that it would only apply to the objects in that direction but I couldn't get it to work. I would guess this also affects a lot of other objects that have particle pixel offsets. Runtime is fixed. Particle offsets are still broken. ## Why It's Good For The Game Fireplaces no more runtime. ## Changelog :cl: fix: Fix fireplace particles runtimes. /:cl:
## About The Pull Request Removes broken flickering lights ## Why It's Good For The Game Lighting is another one of our massive memory usages. Let's remove this. ## Changelog :cl: del: Removes broken light flickering. /:cl:
## About The Pull Request Biodome had multiple missing disposal pipe segments and routing issues, this fixes them all ## Why It's Good For The Game The mail never stops ## Proof Of Testing I wrote a tool to test all disposal units on station making it to disposals and every mail destination ending up in the right place and everything passed ## Changelog :cl: map: fixes Biodome disposals issues. /:cl:
I apologize if anything in the PR format is weird, this is my first PR. The code runs and works. ## About The Pull Request This adds kepi style caps to security multisec vendor and the HoS garment bag. ## Why It's Good For The Game ~~Bubberstation is included in the natural borders of France.~~ More customization is always fun and a few more hats would never hurt! At least three sec players would be happier! ## Proof Of Testing     <details> <summary>Screenshots/Videos</summary> </details> ## Changelog :cl: add: Added kepis to security outfitters /:cl:
… look less bad (Bubberstation#2804) ## About The Pull Request unfortunately i wasn't able to get rid of the nose, but this adds the ability to add a white to the cyclops eye and make it look way less janky ## Why It's Good For The Game cyclops looks ugly and i want to try and make it look potentially look less ugly because i believe in the representation for my cyclops girls out there in the bronx ## Proof Of Testing ## Changelog :cl: add: cyclops sclera marking image: cyclops sclera marking /:cl: --------- Co-authored-by: Waterpig <[email protected]> Co-authored-by: Waterpig <[email protected]>
…e Sauna) (Bubberstation#2864) ## About The Pull Request Adds five pieces of wood, a bucket, and a tinyfan to the Moonstation Sauna ## Why It's Good For The Game Just a few tiny tweaks to moonstation so the sauna is slightly more accessable without needing to go too far out of the way. ## Proof Of Testing Check map dif ## Changelog :cl: add: Quality Improvements to the Moonstation Sauna /:cl:
…ascending (Bubberstation#2854) ## About The Pull Request title ## Why It's Good For The Game This makes it so stealth ascending is pretty much impossible, giving security some time to really get their act together and go stop the bad guy ## Proof Of Testing  <details> <summary>Screenshots/Videos</summary> </details> ## Changelog :cl: balance: Heretics announce themselves when they are 1 off ascending /:cl: --------- Co-authored-by: The Sharkening <[email protected]>
…berstation#2867) ## About The Pull Request Fixes the broken waste pipe, broken emitter cabling, and broken maint cabling around the SM/SMES in Biodome. ## Why It's Good For The Game It was amusing watching it catch fire a few times, but it should be fixed. ## Changelog :cl: LT3 map: Biodome SM waste pipe is properly connected to the vent map: Biodome SM cabling is properly connected to the emitters /:cl:
Remove Saliith plushie and pinpointer definitions from the codebase
…ates [UPSTREAM UPDATE] 9.1.2025
…ions-and-related Erp interaction menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
UPSTREAM UPDATE 09.01.2025
Why It's Good For The Game
Proof Of Testing
Screenshots/Videos
Changelog
🆑
/:cl: