Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters menu fixes #71

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

tplatt77
Copy link
Contributor

  • Fixed the filter menu so the filters get enabled when a valid filter is selected
  • Fixed the sizing issue with the Clip and Slice filters

Tom Platt added 2 commits July 12, 2019 11:45
* Allows user to select Clip, Slice, Threshold, or other filters from Filters menu and/or buttons

Signed-off-by: Tom Platt <[email protected]>
* They do not currently work and will crash IMFViewer if their menu option is clicked

Signed-off-by: Tom Platt <[email protected]>
* Added a function call for setupUi to the creation of each filter's widget

Signed-off-by: Tom Platt <[email protected]>
Copy link
Contributor

@joeykleingers joeykleingers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not ready to be merged, it needs more work. We need all the filters to work as expected before we can merge it in. Let's hold off on this until we have more time to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants