-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: xtensor stores #1001
ENH: xtensor stores #1001
Conversation
@mmarineBlueQuartz Are we adding back in support for GHCFileSystem? All of our compilers that we support no longer need that package. Or is that a dependency for XTensor? |
XTensor. One of the includes was causing errors when it wasn't found. |
d9d63da
to
ec8ae03
Compare
cf38d81
to
ca5f475
Compare
* ResampleImageGeom: Wrong AttributeMatrix dimensions, zeroed out array values. * ApplyTransformationToGeometry: DataArray filled with 0. * InterpolatePointCloudToRegularGrid
* xtensor * xtensor-io
* Enabled disabled unit tests * Remove added debug print statements
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
ca5f475
to
cd3b889
Compare
Closed because there is a new branch to work from. |
Add xtensor-backed data stores to SIMPL NX.
Added data stores for:
Updated DataArray's AbstractDataStore to use xt::xarray
Add vcpkg dependencies for xtensor.
Include xtensor libraries.
Naming Conventions
Naming of variables should descriptive where needed. Loop Control Variables can use
i
if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the filesimplnx/docs/Code_Style_Guide.md
for a more in depth explanation.Filter Checklist
The help file
simplnx/docs/Porting_Filters.md
has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.Unit Testing
The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:
Code Cleanup