ENH: Various ReadPeregrineHDF5File Improvements #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joeykleingers
commented
Jul 11, 2024
•
joeykleingers
commented
- It is now possible to choose to enable/disable the importing of any dataset. If all dataset imports are disabled, then the filter returns an error telling the user that they have to enable at least one dataset import.
- The user can now choose the parent path to the camera data datasets, and can also choose the specific datasets to import using a comma-separated list (similar to the segmentation results comma-separated list).
- Defaults all dataset import boolean parameters to False, since not every Peregrine HDF5 file will have every possible dataset.
- Updated documentation to reflect the changes to the filter parameters.
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
JDuffeyBQ
approved these changes
Jul 12, 2024
imikejackson
pushed a commit
that referenced
this pull request
Jul 12, 2024
- It is now possible to choose to enable/disable the importing of any dataset. If all dataset imports are disabled, then the filter returns an error telling the user that they have to enable at least one dataset import. - The user can now choose the parent path to the camera data datasets, and can also choose the specific datasets to import using a comma-separated list (similar to the segmentation results comma-separated list). - Defaults all dataset import boolean parameters to False, since not every Peregrine HDF5 file will have every possible dataset. - Updated documentation to reflect the changes to the filter parameters. Signed-off-by: Joey Kleingers <[email protected]>
imikejackson
pushed a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
) - It is now possible to choose to enable/disable the importing of any dataset. If all dataset imports are disabled, then the filter returns an error telling the user that they have to enable at least one dataset import. - The user can now choose the parent path to the camera data datasets, and can also choose the specific datasets to import using a comma-separated list (similar to the segmentation results comma-separated list). - Defaults all dataset import boolean parameters to False, since not every Peregrine HDF5 file will have every possible dataset. - Updated documentation to reflect the changes to the filter parameters. Signed-off-by: Joey Kleingers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.