-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Data Array to Store, Speed Optimizations, Code Cleanup (SimplnxCore) #1017
Merged
nyoungbq
merged 24 commits into
BlueQuartzSoftware:develop
from
nyoungbq:enh/data_array_to_store
Aug 23, 2024
Merged
ENH: Data Array to Store, Speed Optimizations, Code Cleanup (SimplnxCore) #1017
nyoungbq
merged 24 commits into
BlueQuartzSoftware:develop
from
nyoungbq:enh/data_array_to_store
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyoungbq
force-pushed
the
enh/data_array_to_store
branch
from
July 12, 2024 14:36
44a2c2a
to
062d06e
Compare
nyoungbq
changed the title
ENH: Data Array to Store and Speed Optimizations
[WIP] ENH: Data Array to Store and Speed Optimizations
Jul 12, 2024
nyoungbq
force-pushed
the
enh/data_array_to_store
branch
from
July 16, 2024 10:58
062d06e
to
16f20af
Compare
nyoungbq
force-pushed
the
enh/data_array_to_store
branch
from
July 23, 2024 11:50
16f20af
to
8613142
Compare
imikejackson
force-pushed
the
enh/data_array_to_store
branch
from
July 30, 2024 12:38
8151f08
to
36036f5
Compare
nyoungbq
changed the title
[WIP] ENH: Data Array to Store and Speed Optimizations
[WIP] ENH: Data Array to Store and Speed Optimizations (SimplnxCore)
Aug 9, 2024
nyoungbq
force-pushed
the
enh/data_array_to_store
branch
2 times, most recently
from
August 9, 2024 18:32
3bca63d
to
68095e4
Compare
nyoungbq
force-pushed
the
enh/data_array_to_store
branch
from
August 20, 2024 16:56
5c4354c
to
d940056
Compare
nyoungbq
changed the title
[WIP] ENH: Data Array to Store and Speed Optimizations (SimplnxCore)
ENH: Data Array to Store, Speed Optimizations, Code Cleanup (SimplnxCore)
Aug 20, 2024
…FeatureCentroids and ComputeFeatureClustering
…eing ignored on STL file read in in the Z dimension
…d store that avoids extra dynamic cast
nyoungbq
force-pushed
the
enh/data_array_to_store
branch
from
August 20, 2024 17:59
10057eb
to
87fa2bb
Compare
JDuffeyBQ
approved these changes
Aug 23, 2024
mmarineBlueQuartz
approved these changes
Aug 23, 2024
imikejackson
pushed a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
…lnxCore) (BlueQuartzSoftware#1017) * extraneous code removal and AbstractDataStore integration for SimplnxCore and main simplnx Utility Files * moved various free functions to an anonymous namespaces * bug fix where duplicate nodes were being ignored on STL file read in in the Z dimension * [1 broken test] All algorithms complete, rework of IDataArray to typed store that avoids extra dynamic cast * Fix Write Stl bug accidentally introduced * Utilities updates * Fix Accidental Boolean Fallthrough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1047
Naming Conventions
Naming of variables should descriptive where needed. Loop Control Variables can use
i
if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the filesimplnx/docs/Code_Style_Guide.md
for a more in depth explanation.Filter Checklist
The help file
simplnx/docs/Porting_Filters.md
has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.Unit Testing
The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:
Code Cleanup