BUG FIX: Remove Python plugin import error handling. #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joeykleingers
commented
Jul 12, 2024
•
joeykleingers
commented
- Removes Python plugin import error handling so that the import errors properly percolate up to C++ and/or the NX GUI. This allows them to be shown to the user in a pop up dialog.
- Modify existing Python plugins (and the C++ filter that generates them) to use relative imports over absolute imports.
…ere. This allows import errors to percolate up to C++ and/or the NX GUI. Signed-off-by: Joey Kleingers <[email protected]>
JDuffeyBQ
approved these changes
Jul 15, 2024
imikejackson
pushed a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
…are#1019) Remove Python plugin error handling, and use relative imports everywhere. This allows import errors to percolate up to C++ and/or the NX GUI. Signed-off-by: Joey Kleingers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.