BUG FIX: PeregrineHDF5Reader Pathing and Array Type Fixes #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joeykleingers
commented
Jul 25, 2024
joeykleingers
commented
- Fixes a bug where the HDF5 paths were not being handed to h5py with forward slashes on Windows.
- Fixes an issue where the filter was not properly reading and taking into account a dataset's data type when importing HDF5 datasets.
Signed-off-by: Joey Kleingers <[email protected]>
…ile. Signed-off-by: Joey Kleingers <[email protected]>
imikejackson
requested review from
imikejackson
and removed request for
JDuffeyBQ
imikejackson
approved these changes
Jul 26, 2024
imikejackson
pushed a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
…lueQuartzSoftware#1025) * BUG FIX: Ensure the path separators are correct for Windows Signed-off-by: Joey Kleingers <[email protected]> * Update arrays to be created using the array data type from the HDF5 file. Signed-off-by: Joey Kleingers <[email protected]> --------- Signed-off-by: Joey Kleingers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.