ENH: Fix compile warnings in FilterUtilities. Init array in DataStore when resizing #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imikejackson
force-pushed
the
topic/misc_updates
branch
from
bbc909f to
69b1ff5
Compare
JDuffeyBQ
requested changes
Jul 29, 2024
|
Requires #1028 |
JDuffeyBQ
force-pushed
the
topic/misc_updates
branch
from
8362f86 to
6f9044a
Compare
nyoungbq
reviewed
Jul 30, 2024
imikejackson
force-pushed
the
topic/misc_updates
branch
3 times, most recently
from
7ba3801 to
b4402d3
Compare
… when resizing Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Co-authored-by: Jared Duffey <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Co-authored-by: Nathan Young <[email protected]>
Co-authored-by: Nathan Young <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
#include <bit> with bit_cast<> was not instroduced until Xcode 14.3 which requires macOS 13.x (Ventura) Signed-off-by: Michael Jackson <[email protected]>
imikejackson
force-pushed
the
topic/misc_updates
branch
from
b4402d3 to
714d1b8
Compare
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
… when resizing (BlueQuartzSoftware#1026) - ENH: Fix compile warnings in FilterUtilities. - Init array in DataStore when resizing - Changes to compile under Xcode 14.2. #include <bit> with bit_cast<> was not instroduced until Xcode 14.3 which requires macOS 13.x (Ventura) -------- Signed-off-by: Michael Jackson <[email protected]> Signed-off-by: Jared Duffey <[email protected]> Co-authored-by: Jared Duffey <[email protected]> Co-authored-by: Nathan Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilterUtilities had a function without a return statement
This change attempts to allow for the initialization value to be used. In case no initialization value is passed into the constructor then a default 0xABAB byte pattern is used instead.