Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Import Image Convert Type #1036

Conversation

nyoungbq
Copy link
Contributor

@nyoungbq nyoungbq commented Aug 2, 2024

ITK Image Reader, ITK Image Stack Reader, and ITK Import Fiji Montage now offer implicit conversion to uint8, uint16, uint32

Naming Conventions

Naming of variables should descriptive where needed. Loop Control Variables can use i if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the file simplnx/docs/Code_Style_Guide.md for a more in depth explanation.

Filter Checklist

The help file simplnx/docs/Porting_Filters.md has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.

Unit Testing

The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:

  • 1 Unit test to test output from the filter against known exemplar set of data
  • 1 Unit test to test invalid input code paths that are specific to a filter. Don't test that a DataPath does not exist since that test is already performed as part of the SelectDataArrayAction.

Code Cleanup

  • No commented out code (rare exceptions to this is allowed..)
  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added example pipelines that use the filter
  • Classes and methods are properly documented

@nyoungbq nyoungbq requested a review from imikejackson August 2, 2024 22:21
@nyoungbq nyoungbq force-pushed the topic/import_image_convert_type branch from e39f40a to 86a5ad8 Compare August 6, 2024 13:08
@imikejackson imikejackson force-pushed the topic/import_image_convert_type branch from 86a5ad8 to 3010d22 Compare August 8, 2024 14:15
@imikejackson imikejackson enabled auto-merge (squash) August 8, 2024 14:16
@imikejackson imikejackson force-pushed the topic/import_image_convert_type branch from 3010d22 to cbedb92 Compare August 8, 2024 19:41
@imikejackson imikejackson merged commit a44f491 into BlueQuartzSoftware:develop Aug 8, 2024
7 checks passed
@nyoungbq nyoungbq deleted the topic/import_image_convert_type branch August 8, 2024 21:19
imikejackson added a commit to imikejackson/simplnx that referenced this pull request Oct 20, 2024
- ITKImageReader
- ITKImageStackReader
- ImportFIJIMontageReader

All updated.

---------

Signed-off-by: Michael Jackson <[email protected]>
Co-authored-by: Michael Jackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants