ENH: AppendImageGeometryZSliceFilter -> AppendImageGeometryFilter #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeykleingers
force-pushed
the
feature/AppendImageGeometrySlices
branch
from
64dd243 to
6582c3b
Compare
joeykleingers
force-pushed
the
feature/AppendImageGeometrySlices
branch
3 times, most recently
from
7263ddb to
d3c76eb
Compare
+ Skeleton code in place to append multiple geometries in any dimension. + Z dimension currently works properly and original test passes. Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
joeykleingers
force-pushed
the
feature/AppendImageGeometrySlices
branch
from
d3c76eb to
9e25f61
Compare
joeykleingers
requested review from
nyoungbq
and removed request for
imikejackson and
JDuffeyBQ
nyoungbq
approved these changes
Aug 13, 2024
imikejackson
pushed a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
…ueQuartzSoftware#1041) * Renamed AppendImageGeometryZSliceFilter to AppendImageGeometryFilter. * Added the ability to append image geometries in the X and Y directions in addition to the Z direction. * Added the ability to append multiple image geometries at once. * Updated unit test to test the X and Y directions. * Updated the documentation. Signed-off-by: Joey Kleingers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following has been added to the AppendImageGeometryZSliceFilter: