Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: AppendImageGeometry now has option to mirror across the chosen axis. #1052

Merged
merged 9 commits into from
Aug 27, 2024
Merged

ENH: AppendImageGeometry now has option to mirror across the chosen axis. #1052

merged 9 commits into from
Aug 27, 2024

Conversation

joeykleingers
Copy link
Contributor

@joeykleingers joeykleingers commented Aug 24, 2024 •
edited
Loading

  • Added option to mirror the entire resulting microstructure across the chosen axis (X, Y, or Z).
  • This required separating the append/combine helper methods into methods specific for X, Y, and Z.

NOTE: SmallIN100_dream3d.tar.gz must be removed from the DataArchive after this PR gets merged in!

@joeykleingers joeykleingers added the enhancement New feature or request label Aug 24, 2024
@joeykleingers joeykleingers self-assigned this Aug 24, 2024
@joeykleingers joeykleingers linked an issue Aug 24, 2024 that may be closed by this pull request
ENH: Append Image Geometry Filter - Add option to 'mirror' the microstructure across a specific axis. #1042
Closed
@joeykleingers joeykleingers force-pushed the topic/AppendImageGeometryMirroring branch from b59fcb5 to ac54a00 Compare August 26, 2024 19:59
@joeykleingers joeykleingers enabled auto-merge (squash) August 27, 2024 12:48
@joeykleingers joeykleingers requested a review from nyoungbq August 27, 2024 14:07
@joeykleingers joeykleingers force-pushed the topic/AppendImageGeometryMirroring branch from 67a8a9d to 8949da4 Compare August 27, 2024 15:11
joeykleingers and others added 9 commits August 27, 2024 12:56
@joeykleingers
ENH: AppendImageGeometry now has option to mirror across the chosen a…
c5e5fc0 
…xis.

Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Fix Linux compile error.
8de7535 
Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Fixing issue where Append X & Y was using the incorrect source dimens…
7f045eb 
…ion.

Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Update parameter human label, etc from "Append Dimension" to "Directi…
683834f 
…on".

Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Update unit test and test file with X,Y,Z mirrored cases.
4f70205 
Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Update the documentation.
7bf032f 
Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Fix unit test failure.
1b521d1 
Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Fix Windows compile errors.
22223b0 
Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers @nyoungbq
Remove inline keyword from StringLiterals in cpp file.
af79db9 
Co-authored-by: Nathan Young <[email protected]>
@joeykleingers joeykleingers force-pushed the topic/AppendImageGeometryMirroring branch from 8949da4 to af79db9 Compare August 27, 2024 16:56
@joeykleingers joeykleingers merged commit 532ad79 into BlueQuartzSoftware:develop Aug 27, 2024
7 checks passed
@joeykleingers joeykleingers deleted the topic/AppendImageGeometryMirroring branch August 28, 2024 18:37
imikejackson pushed a commit to imikejackson/simplnx that referenced this pull request Oct 20, 2024
@joeykleingers @imikejackson
ENH: AppendImageGeometry now has option to mirror across the chosen a…
b86f8ca 
…xis. (BlueQuartzSoftware#1052)

Signed-off-by: Joey Kleingers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyoungbq nyoungbq nyoungbq approved these changes

@imikejackson imikejackson Awaiting requested review from imikejackson

Assignees

@joeykleingers joeykleingers

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: Append Image Geometry Filter - Add option to 'mirror' the microstructure across a specific axis.
2 participants
@joeykleingers @nyoungbq