CI: Added option to download data before compile #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Forces test files to be downloaded before simplnx * This will hopefully fix the issue of downloads failing on the CI sporadically Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
imikejackson
approved these changes
Aug 27, 2024
imikejackson
pushed a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
…1054) * Added SIMPLNX_DOWNLOAD_TEST_FILES_FIRST option * Forces test files to be downloaded before simplnx * This will hopefully fix the issue of downloads failing on the CI sporadically * Enabled SIMPLNX_DOWNLOAD_TEST_FILES_FIRST for CI builds Signed-off-by: Jared Duffey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the CI builds fail when downloading the test data while compiling. The download might not be able to complete due to the compile so this change forces the download to occur before the compile can start. It does this by making the data download target a dependency of simplnx.