Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Modify header files to decrease compiler time. #1064

Conversation

imikejackson
Copy link
Contributor

@imikejackson imikejackson commented Sep 3, 2024

Fixes/Implements #1063

ITK Adjustments implemented.

@imikejackson imikejackson added the enhancement New feature or request label Sep 3, 2024
@imikejackson imikejackson marked this pull request as draft September 3, 2024 19:08
@imikejackson imikejackson force-pushed the topic/compiler_performance branch 6 times, most recently from 325b2b7 to 9a549f8 Compare September 10, 2024 16:09
ITK Adjustments implemented.

Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
@imikejackson
Copy link
Contributor Author

The changes are implemented into another PR.

@imikejackson imikejackson deleted the topic/compiler_performance branch October 16, 2024 20:07
JDuffeyBQ added a commit that referenced this pull request Oct 18, 2024
Supercedes #1064
Fixes #1063

* Moved Application.hpp dependency to DataArrayUtilities.cpp from hpp

Signed-off-by: Jared Duffey <[email protected]>

* Moved GetAllDataTypes and related functions to their own header

Signed-off-by: Jared Duffey <[email protected]>

* Moved StringLiteral fmt formatting to separate header

Signed-off-by: Jared Duffey <[email protected]>

* Replaced itk header with more specific header

* Needed itk::ImageIOBase::IOComponentEnum

Signed-off-by: Jared Duffey <[email protected]>

* Moved some nlohmann json code out of headers

Signed-off-by: Jared Duffey <[email protected]>

* Fixed missing formatting header

Signed-off-by: Jared Duffey <[email protected]>

* Fixed compile issue for msvc v142

Signed-off-by: Jared Duffey <[email protected]>

---------

Signed-off-by: Jared Duffey <[email protected]>
imikejackson pushed a commit to imikejackson/simplnx that referenced this pull request Oct 20, 2024
Supercedes BlueQuartzSoftware#1064
Fixes BlueQuartzSoftware#1063

* Moved Application.hpp dependency to DataArrayUtilities.cpp from hpp

Signed-off-by: Jared Duffey <[email protected]>

* Moved GetAllDataTypes and related functions to their own header

Signed-off-by: Jared Duffey <[email protected]>

* Moved StringLiteral fmt formatting to separate header

Signed-off-by: Jared Duffey <[email protected]>

* Replaced itk header with more specific header

* Needed itk::ImageIOBase::IOComponentEnum

Signed-off-by: Jared Duffey <[email protected]>

* Moved some nlohmann json code out of headers

Signed-off-by: Jared Duffey <[email protected]>

* Fixed missing formatting header

Signed-off-by: Jared Duffey <[email protected]>

* Fixed compile issue for msvc v142

Signed-off-by: Jared Duffey <[email protected]>

---------

Signed-off-by: Jared Duffey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants