Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FILT: CreateDataArray Advanced (Create Data Array + Initialize Data Array) #1066

Conversation

imikejackson
Copy link
Contributor

No description provided.

@imikejackson imikejackson added the enhancement New feature or request label Sep 5, 2024
@imikejackson imikejackson force-pushed the topic/create_array_initialization branch 3 times, most recently from b05475e to 571a0f4 Compare September 5, 2024 00:57
@joeykleingers joeykleingers requested review from JDuffeyBQ and removed request for joeykleingers September 6, 2024 20:02
@joeykleingers joeykleingers enabled auto-merge (squash) September 6, 2024 20:04
@joeykleingers joeykleingers force-pushed the topic/create_array_initialization branch 6 times, most recently from 92cbbf1 to f7edaa5 Compare September 10, 2024 18:02
@joeykleingers joeykleingers linked an issue Sep 13, 2024 that may be closed by this pull request
@imikejackson imikejackson changed the title ENH: Allow CreateDataArray to have all the options of InitializeDataArray FILT: CreateDataArray Advanced (Create Data Array + Initialize Data Array) Sep 19, 2024
Copy link
Contributor Author

@imikejackson imikejackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We probably need to rearrange the parameter order a bit to make the flow of filling out the parameters more cohesive.
  • Need a default for the name of the Data Array, the number of tuples (1) and the number of components (1). I should be able to place the filter and have the basic bits filled out with sane defaults
  • Update the original Create Data Array with these same changes
  • Use some logic to summarize or cut down the preflight updated value when there are more than X number of components? Maybe past 10? I tried to create an array with an 80 x 60 component dimensions...
  • If there isn't already, a short python script showing the use of this filter (since there are a bunch of parameters now). The script can be just the single filter. Nothing fancy.

Screenshot 2024-09-19 at 13 32 12
Can this be cleaned up (for both filters). There is a large amount of text explaining a bunch of things that as a user I'm not sure if I should be taking action of some sort. I feel like what is being presented should be in the documentation and in its place here we should have some sort of a "summary" of what the data might look like.

I am creating an array with multiple components, a suggestion:

Multicomponent Notes: Each tuple will contain the same values for all components: |2,2,2| 9,9,9|.
or
Multicomponent Notes: Each tuple will contain different values for all components: |1,7,9|8,2,1|

Basically, just state what is going to happen. The documentation is there for more detail explanations.

See documentation for other parameter settings.

@joeykleingers joeykleingers requested review from nyoungbq and removed request for JDuffeyBQ September 20, 2024 14:10
imikejackson and others added 10 commits September 23, 2024 10:17
Initialization should be working correctly now.

Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
The user should start from the "top down" when filling out the parameters.

1: Name
2: Type
3: Number of Tuples
4: Number of Components
5: Initialize values.

Signed-off-by: Michael Jackson <[email protected]>
@imikejackson imikejackson force-pushed the topic/create_array_initialization branch from 29356fc to 05a4093 Compare September 23, 2024 14:17
@imikejackson imikejackson merged commit 8f8be48 into BlueQuartzSoftware:develop Sep 24, 2024
7 checks passed
@imikejackson imikejackson deleted the topic/create_array_initialization branch September 24, 2024 20:18
imikejackson added a commit to imikejackson/simplnx that referenced this pull request Oct 20, 2024
…rray) (BlueQuartzSoftware#1066)

- Added new filter that allows more options and to initialize the data array with some set patterns of data (Random, fixed value, indexing)
- Rearrange the parameters a bit to make the flow more logical.

The user should start from the "top down" when filling out the parameters.

1: Name
2: Type
3: Number of Tuples
4: Number of Components
5: Initialize values.

- Added Python script showing how to use advanced Create Data Array filter.

---------

Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Co-authored-by: Joey Kleingers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array Operations: Create Array added functionality
3 participants