-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG/API: Histogram Sync #1073
Merged
nyoungbq
merged 25 commits into
BlueQuartzSoftware:develop
from
nyoungbq:bug/histogram_sync
Sep 26, 2024
Merged
BUG/API: Histogram Sync #1073
nyoungbq
merged 25 commits into
BlueQuartzSoftware:develop
from
nyoungbq:bug/histogram_sync
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imikejackson
force-pushed
the
bug/histogram_sync
branch
from
September 24, 2024 15:36
fc82201
to
36bbda5
Compare
imikejackson
approved these changes
Sep 24, 2024
imikejackson
force-pushed
the
bug/histogram_sync
branch
from
September 24, 2024 20:22
36bbda5
to
72fb894
Compare
JDuffeyBQ
requested changes
Sep 25, 2024
…e with plot.ly histogram
…ut template capture
Co-authored-by: Jared Duffey <[email protected]>
nyoungbq
force-pushed
the
bug/histogram_sync
branch
from
September 25, 2024 16:12
a31a27a
to
3ae2af1
Compare
imikejackson
approved these changes
Sep 25, 2024
JDuffeyBQ
approved these changes
Sep 26, 2024
imikejackson
pushed a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
* Add HistogramUtilities File * Integrated Histogram API into Compute Array Statistics and Compute Array Histogram * complete extensive documentation for histogram utilities * Update test case to reflect new histogram that produces results inline with plot.ly histogram * repair broken pipelines after key updates * Added a size() function to IDataStore for std::vector compatibility * Update CalculateBin for special bool case --------- Co-authored-by: Jared Duffey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1044
Naming Conventions
Naming of variables should descriptive where needed. Loop Control Variables can use
i
if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the filesimplnx/docs/Code_Style_Guide.md
for a more in depth explanation.Filter Checklist
The help file
simplnx/docs/Porting_Filters.md
has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.Unit Testing
The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:
Code Cleanup