ENH: Update Read CSV Filter caching to handle modified files. #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joeykleingers
commented
Sep 19, 2024
•
joeykleingers
commented
- The filter now re-caches required data from the input file if the file has been modified.
joeykleingers
changed the title
Signed-off-by: Joey Kleingers <[email protected]>
1. File path changes 2. File is modified 3. Headers mode is set to LINE and the header line has changed. Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
imikejackson
force-pushed
the
topic/ReadCSVFilterReloading
branch
from
1274c7b to
2af9391
Compare
imikejackson
approved these changes
Sep 23, 2024
imikejackson
pushed a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
…artzSoftware#1078) * Adjust filter to re-read the headers from the header line every time. * Adjust the filter to only re-read the file when the following occurs: 1. File path changes 2. File is modified 3. Headers mode is set to LINE and the header line has changed. --------- Signed-off-by: Joey Kleingers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.