Added versioning to filter parameters and json #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JDuffeyBQ
commented
Sep 30, 2024
JDuffeyBQ
commented
- Added a version to each parameter that is tied to its json layout
- Added a version to each filter that is tied to the specific set of parameters it has
- All filters and parameters start at version 1
- Currently there is not any change in the filter json parsing to switch between parameters versions. This PR is mainly to make sure the version is written out to the json so it can be checked in the future
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
imikejackson
approved these changes
Sep 30, 2024
imikejackson
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Added IFilter::parametersVersion() and IParameter::getVersion() * Updated filter hpp files * Updated filter cpp files * Updated IParameter::fromJson to allow for no version specified * Updated test filters * Updated parameters * Updated python bindings * Updated new filter from rebase * Allowed backwards compatible parameter json reading * Updated pipelines --------- Signed-off-by: Jared Duffey <[email protected]>
imikejackson
pushed a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
* Added IFilter::parametersVersion() and IParameter::getVersion() * Updated filter hpp files * Updated filter cpp files * Updated IParameter::fromJson to allow for no version specified * Updated test filters * Updated parameters * Updated python bindings * Updated new filter from rebase * Allowed backwards compatible parameter json reading * Updated pipelines --------- Signed-off-by: Jared Duffey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.