BUG FIX: Data object parent ids are now renumbered correctly when object id clashes are found. #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joeykleingers
commented
Oct 9, 2024
joeykleingers
commented
- Fixes a bug where if a DREAM3D file is read into a data structure that already has existing data objects in it and the file is read in without specifying data paths, then an infinite loop occurs when getting the data paths of each object. This ONLY happens when using Python or executing non-GUI C++ code because the GUI never leaves the data paths variable empty. This is because the data object parent ids were getting renumbered incorrectly.
- Added an additional unit test case to DREAM3DFileTest to test that this is working correctly.
joeykleingers
force-pushed
the
bug_fix/DS_ParentIds_Renumbering
branch
from
460ae43 to
d1ff0bf
Compare
joeykleingers
force-pushed
the
bug_fix/DS_ParentIds_Renumbering
branch
from
d1ff0bf to
2a88079
Compare
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
imikejackson
force-pushed
the
bug_fix/DS_ParentIds_Renumbering
branch
from
2a88079 to
b4e0e8c
Compare
imikejackson
approved these changes
Oct 10, 2024
imikejackson
pushed a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
…ect id clashes are found. (BlueQuartzSoftware#1102) * Fixes a bug where if a DREAM3D file is read into a data structure that already has existing data objects in it and the file is read in without specifying data paths, then an infinite loop occurs when getting the data paths of each object. This ONLY happens when using Python or executing non-GUI C++ code because the GUI never leaves the data paths variable empty. This is because the data object parent ids were getting renumbered incorrectly. * Added an additional unit test case to DREAM3DFileTest to test that this is working correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.