Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FILT: Add 'Read GrainMapper3D' filter #1107

Merged
merged 2 commits into from
Oct 17, 2024
Merged

FILT: Add 'Read GrainMapper3D' filter #1107

merged 2 commits into from
Oct 17, 2024

Conversation

imikejackson
Copy link
Contributor

@imikejackson imikejackson commented Oct 16, 2024 •
edited
Loading

@imikejackson imikejackson requested a review from nyoungbq October 16, 2024 20:06
@imikejackson imikejackson changed the title ENH: Add function to compare a pair of attribute matrix. FILT: Add 'Read GrainMapper3D' filter Oct 16, 2024
@imikejackson imikejackson force-pushed the topic/unit_test_common_compare_attribute_matrix branch from ef9b8d2 to 8ad9865 Compare October 16, 2024 20:27
@imikejackson imikejackson requested a review from nyoungbq October 16, 2024 20:27
@imikejackson imikejackson enabled auto-merge (squash) October 16, 2024 20:28
nyoungbq
nyoungbq approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@nyoungbq nyoungbq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A possible feature that can be added in a later version would be file caching, so it doesn't have to be re-read in execute after preflight. That said it may be a fairly fast format so parsing twice may not matter.

@imikejackson imikejackson force-pushed the topic/unit_test_common_compare_attribute_matrix branch from 8ad9865 to e08bbae Compare October 16, 2024 22:12
@imikejackson
ENH: Add function to compare a pair of attribute matrix.
c52fb5e 
Signed-off-by: Michael Jackson <[email protected]>
@imikejackson
FILTER: Add Read GrainMapper3D filter
1200233 
This will read version 4 and 5 native HDF5 files from XNovo.

Signed-off-by: Michael Jackson <[email protected]>
@imikejackson imikejackson force-pushed the topic/unit_test_common_compare_attribute_matrix branch from e08bbae to 1200233 Compare October 17, 2024 12:35
@imikejackson imikejackson disabled auto-merge October 17, 2024 12:35
@imikejackson imikejackson merged commit 7b6d091 into BlueQuartzSoftware:develop Oct 17, 2024
7 checks passed
@imikejackson imikejackson deleted the topic/unit_test_common_compare_attribute_matrix branch October 17, 2024 12:35
imikejackson added a commit to imikejackson/simplnx that referenced this pull request Oct 20, 2024
@imikejackson
FILT: Add 'Read GrainMapper3D' filter (BlueQuartzSoftware#1107)
3684919 
* FILTER: Add Read GrainMapper3D filter. This will read version 4 and 5 native HDF5 files from Xnovo Technologies.
* ENH: Add function to compare a pair of attribute matrix.

---------

Signed-off-by: Michael Jackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyoungbq nyoungbq nyoungbq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imikejackson @nyoungbq