ENH: Filters use consistent ordering for Spacing and Origin for ImageGeometries #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyoungbq
approved these changes
Dec 4, 2024
imikejackson
force-pushed
the
topic/image_geom_spacing_origin_parameter_order
branch
from
2cd379a to
47f330c
Compare
…Geometries Signed-off-by: Michael Jackson <[email protected]>
imikejackson
force-pushed
the
topic/image_geom_spacing_origin_parameter_order
branch
from
47f330c to
83af2e5
Compare
imikejackson
deleted the
topic/image_geom_spacing_origin_parameter_order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user should be presented with a consistent ordering of parameters that all deal with the same thing. In this case the values for the dimensions, origin and spacing for Image Geometry objects should all be presented to the user in the same order.