Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FILTER: Crop Edge Geometry #1153

Merged
merged 9 commits into from
Dec 11, 2024
Merged

FILTER: Crop Edge Geometry #1153

merged 9 commits into from
Dec 11, 2024

Conversation

joeykleingers
Copy link
Contributor

  • Adds the Crop Edge Geometry filter, which can crop an edge geometry and allow the user to pick the boundary intersection behavior (filter error, ignore edge, interpolate outside vertex).
  • Includes documentation and a unit test.

When the Interpolate Outside Vertex boundary intersection behavior is chosen, this filter DOES NOT interpolate any vertex data, only the vertex position!

@joeykleingers joeykleingers added the Filter Adds a new filter label Dec 4, 2024
@joeykleingers joeykleingers self-assigned this Dec 4, 2024
nyoungbq
nyoungbq reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@nyoungbq nyoungbq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CropEdgeGeometryFilter.cpp and CropEdgeGeometryTest.cpp need newlines at end of file.

src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/CropEdgeGeometry.cpp Outdated Show resolved Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/CropEdgeGeometry.cpp Outdated Show resolved Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/CropEdgeGeometry.cpp Outdated Show resolved Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/CropEdgeGeometry.cpp Outdated Show resolved Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/CropEdgeGeometry.cpp Outdated Show resolved Hide resolved
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/CropEdgeGeometry.cpp Show resolved Hide resolved
@joeykleingers joeykleingers force-pushed the filter/CropEdgeGeometryFilter branch from 32c5006 to f037646 Compare December 8, 2024 17:11
@joeykleingers
FILTER: Add CropEdgeGeometry filter.
2f7a188 
Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Referenced vertices and kept edges are now counted correctly.
954be2c 
Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Add documentation.
04ee39a 
Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Add unit test.
d863fcb 
Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Add warning message about vertex data not being interpolated.
ed69257 
Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Update filter documentation with a note.
0cd592d 
Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Fix cross-platform compile errors.
a074350 
Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Fix unit test failure.
3f9a7fa 
Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers
Implement PR review suggestions.
ebda06c 
Signed-off-by: Joey Kleingers <[email protected]>
@joeykleingers joeykleingers force-pushed the filter/CropEdgeGeometryFilter branch from f037646 to ebda06c Compare December 10, 2024 15:51
@joeykleingers joeykleingers merged commit 6b590b0 into BlueQuartzSoftware:develop Dec 11, 2024
7 checks passed
@imikejackson imikejackson deleted the filter/CropEdgeGeometryFilter branch December 19, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyoungbq nyoungbq nyoungbq approved these changes

Assignees

@joeykleingers joeykleingers

Labels
Filter Adds a new filter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeykleingers @nyoungbq