Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FILTER: ITK Projection Filters #1162

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

nyoungbq
Copy link
Contributor

Naming Conventions

Naming of variables should descriptive where needed. Loop Control Variables can use i if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the file simplnx/docs/Code_Style_Guide.md for a more in depth explanation.

Filter Checklist

The help file simplnx/docs/Porting_Filters.md has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.

Unit Testing

The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:

  • 1 Unit test to test output from the filter against known exemplar set of data
  • 1 Unit test to test invalid input code paths that are specific to a filter. Don't test that a DataPath does not exist since that test is already performed as part of the SelectDataArrayAction.

Code Cleanup

  • No commented out code (rare exceptions to this is allowed..)
  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added example pipelines that use the filter
  • Classes and methods are properly documented

imikejackson and others added 9 commits December 13, 2024 16:59
…angleGeometrySizes (BlueQuartzSoftware#1134)

* BUG: Fixes issue where any component shape were allowed for ComputeTriangleGeometrySizes.cpp
* Fix all instances of "Face Labels" are only allowed to use 2 component input arrays
* ComputeTriangleGeomVolumes - fix possible walking off the end of the array.
	A negative value for the face label when used as an index will cast into an unsigned value and bad things are going to happen.
* BUG: Fixes negative volumes produced from calculations

---------

Signed-off-by: Michael Jackson <[email protected]>
…efault)

Done by creating a new resized geom with only projected data in it
@nyoungbq nyoungbq requested review from imikejackson and JDuffeyBQ and removed request for imikejackson December 13, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants