Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FIX: MeshIO writer code now writes cell data properly. #1166

Merged
merged 1 commit into from
Jan 6, 2025
Merged

BUG FIX: MeshIO writer code now writes cell data properly. #1166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...hon/plugins/NXDataAnalysisToolkit/src/NXDataAnalysisToolkit/utilities/meshio_utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,12 @@ def create_mesh(file_format: str, data_structure: nx.DataStructure, input_geomet

# Create meshio cell_data
if cell_data_array_paths is not None:
cell_data = {}
for data_array_path in cell_data_array_paths:
data_array = data_structure[data_array_path]
if data_array.tdims != geom_cell_tdims:
return None, nx.Result(errors=[nx.Error(-4010, f"Cell data array '{data_array_path}' has tuple dimensions {data_array.tdims} but the input geometry requires tuple dimensions {geom_cell_tdims}.")])
cell_data[data_array.name.replace(' ', '') if remove_array_name_spaces else data_array.name] = np.squeeze(data_array.npview()) # Remove spaces in cell data array names (this is required for some formats like VTK)
cell_data[data_array.name.replace(' ', '') if remove_array_name_spaces else data_array.name] = [np.squeeze(data_array.npview()).flatten()] # Remove spaces in cell data array names (this is required for some formats like VTK)

# Create meshio point_data
point_data = {}
Expand All @@ -84,11 +85,10 @@ def create_mesh(file_format: str, data_structure: nx.DataStructure, input_geomet
data_array = data_structure[data_array_path]
if data_array.tdims != geom.vertices.tdims:
return None, nx.Result(errors=[nx.Error(-4011, f"Point data array '{data_array_path}' has tuple dimensions {data_array.tdims} but the input geometry point data requires tuple dimensions {geom.vertices.tdims}.")])
point_data[data_array.name.replace(' ', '') if remove_array_name_spaces else data_array.name] = np.squeeze(data_array.npview()) # Remove spaces in point data array names (this is required for some formats like VTK)
point_data[data_array.name.replace(' ', '') if remove_array_name_spaces else data_array.name] = [np.squeeze(data_array.npview()).flatten()] # Remove spaces in point data array names (this is required for some formats like VTK)

# Create meshio Mesh
mesh = meshio.Mesh(points=list(geom.vertices.npview().astype(np.float64)), cells=cells, cell_data=cell_data, point_data=point_data)

return mesh, nx.Result()

def execute_meshio_writer_filter(file_format: str, data_structure: nx.DataStructure, input_geometry_path: nx.DataPath, cell_data_array_paths: List[nx.DataPath], point_data_array_paths: List[nx.DataPath], output_file_path: Path, message_handler: nx.IFilter.MessageHandler, should_cancel: nx.AtomicBoolProxy, remove_array_name_spaces: bool = False, **write_kwargs):
Expand Down
Loading