-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] FILTER: Merge Colonies #620
Closed
nyoungbq
wants to merge
8
commits into
BlueQuartzSoftware:develop
from
nyoungbq:filter/merge_colonies
Closed
[WIP] FILTER: Merge Colonies #620
nyoungbq
wants to merge
8
commits into
BlueQuartzSoftware:develop
from
nyoungbq:filter/merge_colonies
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyoungbq
force-pushed
the
filter/merge_colonies
branch
2 times, most recently
from
June 27, 2023 14:35
786b44b
to
bf2a88f
Compare
imikejackson
force-pushed
the
filter/merge_colonies
branch
from
July 3, 2023 12:31
bf2a88f
to
ea43fe6
Compare
nyoungbq
force-pushed
the
filter/merge_colonies
branch
2 times, most recently
from
July 6, 2023 12:09
fd477d3
to
e87885b
Compare
nyoungbq
force-pushed
the
filter/merge_colonies
branch
from
July 13, 2023 14:39
e87885b
to
dce2df9
Compare
nyoungbq
force-pushed
the
filter/merge_colonies
branch
from
September 25, 2023 19:06
dce2df9
to
a22db01
Compare
nyoungbq
force-pushed
the
filter/merge_colonies
branch
from
October 3, 2023 14:20
a22db01
to
55fb224
Compare
nyoungbq
force-pushed
the
filter/merge_colonies
branch
from
October 10, 2023 17:00
55fb224
to
4015f99
Compare
…nies.hpp, and 3 more files
…s.cpp, and 13 more files
nyoungbq
force-pushed
the
filter/merge_colonies
branch
from
October 17, 2023 18:56
4015f99
to
7c5dde4
Compare
imikejackson
force-pushed
the
develop
branch
from
December 22, 2023 16:59
f1927c5
to
95265d6
Compare
This filter was moved to simplnxreview until we can get data for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting on data from client
Naming Conventions
Naming of variables should descriptive where needed. Loop Control Variables can use
i
if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the filecomplex/docs/Code_Style_Guide.md
for a more in depth explanation.Filter Checklist
The help file
complex/docs/Porting_Filters.md
has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.Unit Testing
The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:
Code Cleanup