Replaced CMAKE_CFG_INTDIR with $<CONFIG> #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JDuffeyBQ
commented
Sep 1, 2023
JDuffeyBQ
commented
- CMAKE_CFG_INTDIR is deprecated
- Fixes packaging with Visual Studio generator
- Removed file(MAKE_DIRECTORY) calls that use variables with $ since it can't use generator expressions and the calls aren't required
imikejackson
force-pushed
the
fix/cmake_install_configuration
branch
2 times, most recently
from
a5e910b to
9b7db66
Compare
imikejackson
force-pushed
the
fix/cmake_install_configuration
branch
2 times, most recently
from
c80eb2f to
9345841
Compare
* CMAKE_CFG_INTDIR is deprecated * Fixes packaging with Visual Studio generator * Removed file(MAKE_DIRECTORY) calls that use variables with $<CONFIG> since it can't use generator expressions and the calls aren't required Signed-off-by: Jared Duffey <[email protected]>
imikejackson
force-pushed
the
fix/cmake_install_configuration
branch
from
9345841 to
fcbd51f
Compare
imikejackson
approved these changes
Oct 13, 2023
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
* Replaced CMAKE_CFG_INTDIR with $<CONFIG> * CMAKE_CFG_INTDIR is deprecated * Fixes packaging with Visual Studio generator * Removed file(MAKE_DIRECTORY) calls that use variables with $<CONFIG> since it can't use generator expressions and the calls aren't required * Use $<CONFIG> or "." depending if the generator is multi-config * Visual Studio fixes build, install, help generation * Single and multi-config install rule fixes --------- Signed-off-by: Jared Duffey <[email protected]> Signed-off-by: Michael Jackson <[email protected]> Co-authored-by: Michael Jackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.