BUG: Fixes to several filters as reported by users #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Jackson <[email protected]>
…rong. Output does match D3D 6.6 though which is good. Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
nyoungbq
approved these changes
Sep 26, 2023
Comment on lines
+321
to
+329
| // float inverseRate = static_cast<float>(diff) / static_cast<float>(m_ProgressCounter - m_LastProgressInt); | ||
| // auto remainMillis = std::chrono::milliseconds(static_cast<int64>(inverseRate * (totalFeatures - m_ProgressCounter))); | ||
| // auto secs = std::chrono::duration_cast<std::chrono::seconds>(remainMillis); | ||
| // remainMillis -= std::chrono::duration_cast<std::chrono::milliseconds>(secs); | ||
| // auto mins = std::chrono::duration_cast<std::chrono::minutes>(secs); | ||
| // secs -= std::chrono::duration_cast<std::chrono::seconds>(mins); | ||
| // auto hour = std::chrono::duration_cast<std::chrono::hours>(mins); | ||
| // mins -= std::chrono::duration_cast<std::chrono::minutes>(hour); | ||
| // progMessage += fmt::format(" || Est. Time Remain: {} hours {} minutes {} seconds", hour.count(), mins.count(), secs.count()); |
There was a problem hiding this comment.
Suggested change
| // float inverseRate = static_cast<float>(diff) / static_cast<float>(m_ProgressCounter - m_LastProgressInt); | |
| // auto remainMillis = std::chrono::milliseconds(static_cast<int64>(inverseRate * (totalFeatures - m_ProgressCounter))); | |
| // auto secs = std::chrono::duration_cast<std::chrono::seconds>(remainMillis); | |
| // remainMillis -= std::chrono::duration_cast<std::chrono::milliseconds>(secs); | |
| // auto mins = std::chrono::duration_cast<std::chrono::minutes>(secs); | |
| // secs -= std::chrono::duration_cast<std::chrono::seconds>(mins); | |
| // auto hour = std::chrono::duration_cast<std::chrono::hours>(mins); | |
| // mins -= std::chrono::duration_cast<std::chrono::minutes>(hour); | |
| // progMessage += fmt::format(" || Est. Time Remain: {} hours {} minutes {} seconds", hour.count(), mins.count(), secs.count()); |
| m_InitialTime = std::chrono::steady_clock::now(); | ||
| m_LastProgressInt = m_ProgressCounter; | ||
| m_LastUpdateTime = std::chrono::steady_clock::now(); | ||
| // m_LastProgressInt = m_ProgressCounter; |
There was a problem hiding this comment.
Suggested change
| // m_LastProgressInt = m_ProgressCounter; |
Comment on lines
+583
to
+584
| // std::array<Point3D<T>, 3> coords; | ||
| // triangleGeom.getFaceCoordinates(faceIds[face], coords); |
There was a problem hiding this comment.
Suggested change
| // std::array<Point3D<T>, 3> coords; | |
| // triangleGeom.getFaceCoordinates(faceIds[face], coords); |
|
Closing as these changes are going to be on another PR or 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WriteSTLFile
SampleTriangleGeometryOntoRegularGrid.