ENH: Add proper sample and crystal reference frame rotations to pipelines #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pipelines Signed-off-by: Michael Jackson <[email protected]>
imikejackson
force-pushed
the
feature/pipeline_corrections
branch
from
96c55ac to
600921d
Compare
imikejackson
requested review from
joeykleingers
and removed request for
nyoungbq
joeykleingers
approved these changes
Oct 9, 2023
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
… pipelines (BlueQuartzSoftware#734) Signed-off-by: Michael Jackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic pipeline of reading a .ang or a .ctf file were missing critical filters to set the crystal and sample reference frame correctly.