ENH: Create DataModifiedAction that marks DataObjects as being modified by a filter #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imikejackson
changed the title
imikejackson
force-pushed
the
feature/data_modified_feedback
branch
4 times, most recently
from
284cf4d to
b101542
Compare
imikejackson
added
bug
imikejackson
changed the title
imikejackson
force-pushed
the
feature/data_modified_feedback
branch
3 times, most recently
from
964e346 to
5a0d8bb
Compare
JDuffeyBQ
previously requested changes
Oct 20, 2023
JDuffeyBQ
reviewed
Oct 24, 2023
imikejackson
force-pushed
the
feature/data_modified_feedback
branch
from
67884a6 to
ada25ee
Compare
imikejackson
dismissed
JDuffeyBQ’s stale review
Applied all requested feedback
…ed by a filter Signed-off-by: Michael Jackson <[email protected]>
…fied/deleted Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
imikejackson
force-pushed
the
feature/data_modified_feedback
branch
from
ada25ee to
58b2165
Compare
JDuffeyBQ
approved these changes
Oct 25, 2023
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
…ed by a filter (BlueQuartzSoftware#735) * Update filters with information about which DataArrays are being modified/deleted * Fix broken pipelines * Clean up more filter arguments and pipeline files * Store DataObject::Type in the DataObjectModification struct. --------- Signed-off-by: Michael Jackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These additions allow a user interface to show to the user which arrays (if any) are being modified by the filter.
For example, the "Minimum Size" filter will most likely modify the Feature Ids array and then every array in the feature attribute matrix. These additions will store information about these modifications in the IDataActions vector which is communicated to the user interface.
Each filter will need to be reviewed for existing array modifications and then updated with code to add the DataModifiedAction during prefilight. There are probably only a handful of these filters to update. Hopefully.