ENH: Output files written to temp, then copied to final filename when closed #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… closed. Signed-off-by: Michael Jackson <[email protected]>
imikejackson
force-pushed
the
feature/save_file_atomically
branch
from
7d91329 to
9f2ebc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of a class that can assist the developer to write to a final file name in a more atomic fashion. The current API is pretty sparse but does have a few features:
Auto commit the temporary file to final file name when the class is destroyed. I bet there would be issues with this so we may want to rethink this idea. Mainly throwing exceptions in destructors.
The class will generate a random file extension to use at the same level as the original file.
There is an API to remove the temp file.
@JDuffeyBQ Please review this first pass and let me know your thoughts.