STYLE: Standardize I/O Naming to Read/Write #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyoungbq
force-pushed
the
enh/standardize_io_naming
branch
2 times, most recently
from
67c379a to
9cfe9b2
Compare
imikejackson
force-pushed
the
enh/standardize_io_naming
branch
from
9cfe9b2 to
5e5cb65
Compare
nyoungbq
force-pushed
the
enh/standardize_io_naming
branch
from
5e5cb65 to
1779c7c
Compare
imikejackson
force-pushed
the
enh/standardize_io_naming
branch
from
1779c7c to
313c6ab
Compare
I/O Renaming ComplexCore
OrientationAnalysis
|
nyoungbq
force-pushed
the
enh/standardize_io_naming
branch
from
313c6ab to
cebb965
Compare
imikejackson
force-pushed
the
enh/standardize_io_naming
branch
from
cebb965 to
330ede1
Compare
This is due to the renaming of the filters which causes API changes. Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
imikejackson
force-pushed
the
enh/standardize_io_naming
branch
from
c658b81 to
7ee5e7b
Compare
imikejackson
approved these changes
Nov 13, 2023
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
* AbaqusHexahedronWriter -> WriteAbaqusHexahedron * AvizoRectilinearCoordinateWriter -> WriteAvizoRectilinearCoordinate * AvizoUniformCoordinateWriter -> WriteAvizoUniformCoordinate * ComplexCore Algorithm renaming * Complete complexcore io rename update * Rename OrientationAnalysis i/o * Sort cmake lists alphabetical * Update ITK I/O human names * Update version to 1.2.0 * Fixing various python related codes * FindFeaturePhases: Change k_FeaturePhasesArrayName_Key value * Python: Adjust release notes structure to separate versions. * Rename the ImportHDFDatasetParameter to ReadHDF5DataSetParameter * Rename the H5EbsdReaderParameter to ReadH5EbsdFileParameter * Upate python codes to WriteDREAM3DFilter * Fix runtime exception when parent file path is empty. Signed-off-by: Michael Jackson <[email protected]> --------- Signed-off-by: Michael Jackson <[email protected]> Co-authored-by: Michael Jackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed all I/O filters to read/write as instructed. The documentation, test cases, filters, and algorithms were all renamed in the ComplexCore and OrientationAnalysis plugins. The ITK plugin was untouched aside from the human names being changed to make them propagate with similar filters. CMake file declarations reordered to conform to A-Z sorting, and small stylistic bug fixes I came across while working on this branch.