-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: pipeline conversion #779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarquisbq
requested review from
imikejackson,
joeykleingers,
JDuffeyBQ and
nyoungbq
November 29, 2023 15:29
jmarquisbq
force-pushed
the
feature/pipeline_conversion
branch
from
November 29, 2023 16:28
dc4057d
to
6d26458
Compare
src/Plugins/ComplexCore/src/ComplexCore/Filters/AlignSectionsListFilter.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/ComplexCore/src/ComplexCore/Filters/AlignSectionsListFilter.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/ComplexCore/src/ComplexCore/Filters/AlignSectionsListFilter.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/ComplexCore/src/ComplexCore/Filters/CalculateArrayHistogramFilter.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/ComplexCore/src/ComplexCore/Filters/CombineAttributeArraysFilter.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/ComplexCore/src/ComplexCore/Filters/PointSampleTriangleGeometryFilter.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/ComplexCore/src/ComplexCore/Filters/PointSampleTriangleGeometryFilter.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/ComplexCore/src/ComplexCore/Filters/TriangleNormalFilter.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/ITKImageProcessing/src/ITKImageProcessing/Filters/ITKImageReader.cpp
Outdated
Show resolved
Hide resolved
jmarquisbq
force-pushed
the
feature/pipeline_conversion
branch
2 times, most recently
from
December 1, 2023 15:10
b406777
to
2204f3d
Compare
jmarquisbq
force-pushed
the
feature/pipeline_conversion
branch
from
December 5, 2023 15:05
b35e179
to
7f4ce81
Compare
nyoungbq
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part a few changes. I appreciated the addition of the NX-Runner documentation.
src/Plugins/ComplexCore/src/ComplexCore/Filters/FindBiasedFeaturesFilter.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/ComplexCore/src/ComplexCore/Filters/FindBoundaryCellsFilter.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/ComplexCore/src/ComplexCore/Filters/FindNeighborListStatistics.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/ComplexCore/src/ComplexCore/Filters/FindSurfaceFeatures.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/ComplexCore/src/ComplexCore/Filters/FindSurfaceFeatures.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/ComplexCore/src/ComplexCore/Filters/ExtractInternalSurfacesFromTriangleGeometry.cpp
Outdated
Show resolved
Hide resolved
src/Plugins/ComplexCore/src/ComplexCore/Filters/ConvertColorToGrayScaleFilter.cpp
Outdated
Show resolved
Hide resolved
imikejackson
force-pushed
the
feature/pipeline_conversion
branch
from
December 10, 2023 21:58
aef8aa9
to
590129e
Compare
nyoungbq
reviewed
Dec 15, 2023
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
* CreateDataArray, CreateDataGroup, and CreateAttributeMatrix have their conversion functions implemented Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
* Removed unnecessary inline * Added fallthrough annotation * Added anonymous namespace Signed-off-by: Jared Duffey <[email protected]>
* ArrayCreation to AttributeMatrixSelection & DataObjectName * ArraySelection to ArraySelection * ArraySelection to GeometrySelection
* LinkedPathCreation to DataObjectName * AttributeMatrixSelection to AttributeMatrixSelection
* Float/Double FilterParameter to NumberParameter<float32/float64>
* Bool/LinkedBool FilterParameter to BoolParameter
Signed-off-by: Jared Duffey <[email protected]>
* ITK filters
* Added Rescale Intensity Image * Added ITK Legacy UUID Mapping
* Orientation Analysis
* Orientation Analysis
* ComplexCore
* Read CSV Filter was redesigned and json porting needs to be redone.
* Updated UseMask and MaskPath keys
* Update for develop rebase
Filters do not come with arguments if encountering an error during SIMPL pipeline conversion
…version fails to find filter
* Add documentation for CMake generation. * Improve description for each of the commands. * Add examples for using each of the commands. Fixes #731
mmarineBlueQuartz
force-pushed
the
feature/pipeline_conversion
branch
from
December 15, 2023 18:44
dc20f61
to
a661f34
Compare
imikejackson
approved these changes
Dec 15, 2023
Signed-off-by: Michael Jackson <[email protected]>
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
* Added utility functions to Result.hpp * Added IFilter::getDefaultArguments * Added pipeline conversion functionality * Added python script to generate SIMPL json conversion code * Added convert option to nxrunner * Use placeholder (null IFilter) and continue converting when SIMPL conversion fails to find filter * Update NX Runner documentation * Add text to filter conversion error hinting to use for further actions --------- Signed-off-by: Jared Duffey <[email protected]> Signed-off-by: Michael Jackson <[email protected]> Co-authored-by: Jared Duffey <[email protected]> Co-authored-by: Matthew Marine <[email protected]> Co-authored-by: Michael Jackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming Conventions
Naming of variables should descriptive where needed. Loop Control Variables can use
i
if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the filecomplex/docs/Code_Style_Guide.md
for a more in depth explanation.Filter Checklist
The help file
complex/docs/Porting_Filters.md
has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.Unit Testing
The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:
Code Cleanup