BUG: ReadStlFile-Fix error logic when reading an ASCII STL File. #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imikejackson
force-pushed
the
feature/stl_reader_fixes
branch
from
a59f4c4 to
e580344
Compare
nyoungbq
changed the title
nyoungbq
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Looks good for the most part. The enum was a good choice and the new algorithm for conversion looks alright. That said, I think it should probably get a test case, but I understand if this is more of a utility function and it doesn't use stuff outside standard c++ so it might be okay to worry about testing later
Add an experimental function to convert from ASCI file to a binary STL file. This could be used in the actual filter to add support for reading ASCII STL files. Signed-off-by: Michael Jackson <[email protected]>
imikejackson
force-pushed
the
feature/stl_reader_fixes
branch
from
e580344 to
ce87e64
Compare
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
…eQuartzSoftware#839) Signed-off-by: Michael Jackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an experimental function to convert from ASCI file to a binary STL file. This could be used in the actual filter to add support for reading ASCII STL files.