Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix resetting of the DataStructure::Id when importing from a file. #879

Conversation

imikejackson
Copy link
Contributor

No description provided.

@imikejackson imikejackson force-pushed the feature/datastructure_update_ids branch 2 times, most recently from befb287 to 7be9c6c Compare March 6, 2024 11:06
Copy link
Collaborator

@mmarineBlueQuartz mmarineBlueQuartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a code segment in INodeGeometry1D that should probably be deleted since it was disabled, but otherwise this looks ready to merge

src/simplnx/DataStructure/Geometry/INodeGeometry1D.cpp Outdated Show resolved Hide resolved
@imikejackson imikejackson force-pushed the feature/datastructure_update_ids branch from 7be9c6c to ffdc030 Compare March 6, 2024 15:13
@imikejackson imikejackson merged commit 8e4e8f9 into BlueQuartzSoftware:develop Mar 6, 2024
8 checks passed
@imikejackson imikejackson deleted the feature/datastructure_update_ids branch March 6, 2024 15:13
imikejackson added a commit to imikejackson/simplnx that referenced this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants