ENH/BUG: Add DataStructure::validateGeometries() method #903
Conversation
There was a problem hiding this comment.
Of note, this does not actually check the AttributeMatrix validity (what prevents importing data) beyond that of a single DataArray that each AttributeMatrix that relates to a geometry contains. To solve this, each of those matrices would have to loop over their arrays and check tuple counts individually.
Similarly to any geometry not at the top-level of the DataStructure (montage groupings, perchance?), this will not find any AttributeMatrix not specifically created through a geometry. We have a CreateAttributeMatrix filter in Core, so the import dream3d error is not necessarily solved with just checking geometries. Add a DataStructure::validateMatrices() method as well, and both this and my previous point will be solved.
imikejackson
force-pushed
the
topic/geometry_validation
branch
from
348c956 to
48b8cfd
Compare
imikejackson
force-pushed
the
topic/geometry_validation
branch
from
48f21d5 to
786c5be
Compare
imikejackson
force-pushed
the
topic/geometry_validation
branch
from
786c5be to
5b5c738
Compare
This method is run by IFilter::execute() after the actual filter's executeImpl() is run. The code will validate that the geometry's Attribute Matrices are correctly sized to match the vertex/edge/face/cell shared lists. Some filters and unit tests bugs were also found and fixed by this update. Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
imikejackson
force-pushed
the
topic/geometry_validation
branch
from
7d31b11 to
c343f17
Compare
…uteMatrices() method (BlueQuartzSoftware#903) This ensures that each geometry and AttributeMatrix are all consistent with DataArray Lengths and total number of tuples. Signed-off-by: Michael Jackson <[email protected]>
This method is run by IFilter::execute() after the actual filter's executeImpl() is run. The code will validate that the geometry's Attribute Matrices are correctly sized to match the vertex/edge/face/cell shared lists.
Some filters and unit tests bugs were also found and fixed by this update.