Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PY: Add infrastructure to allow python plugins to be reloaded in a GUI. #910

Merged
merged 21 commits into from
Apr 22, 2024
Merged

PY: Add infrastructure to allow python plugins to be reloaded in a GUI. #910

merged 21 commits into from
Apr 22, 2024

Conversation

JDuffeyBQ
Copy link
Collaborator

  • Pipelines can now optionally create placeholder filters when they fail to read a filter's json
  • Placeholder filters store the original json and can be used to restore the filter if possible later

@JDuffeyBQ JDuffeyBQ requested a review from imikejackson April 3, 2024 20:55
@imikejackson imikejackson force-pushed the feature/python_reload branch from 9d136bc to d1f0126 Compare April 4, 2024 01:11
@imikejackson
Copy link
Contributor

`AttributeError: 'NoneType' object has no attribute 'get_ident'

At:
(373): release
(421): exit
(848): _exec
/opt/local/anaconda3/envs/nxpython/lib/python3.12/importlib/init.py(136): reload
(279): deep_reload_hook
(311): reload`

@JDuffeyBQ JDuffeyBQ force-pushed the feature/python_reload branch from d1f0126 to 47ee12d Compare April 9, 2024 19:52
@imikejackson imikejackson force-pushed the feature/python_reload branch 3 times, most recently from 06ec2be to 809f1c1 Compare April 15, 2024 16:43
@imikejackson imikejackson force-pushed the feature/python_reload branch 2 times, most recently from 6adb3fe to 0d2f7e9 Compare April 19, 2024 13:03
@imikejackson imikejackson changed the title Improved python reload capability PY: Added infrastructure to allow python plugins to be reloaded in a GUI. Apr 19, 2024
@JDuffeyBQ JDuffeyBQ force-pushed the feature/python_reload branch from 66bd21b to 90488f2 Compare April 19, 2024 20:18
@imikejackson imikejackson force-pushed the feature/python_reload branch from 90488f2 to 02b7fa6 Compare April 22, 2024 13:19
@imikejackson imikejackson changed the title PY: Added infrastructure to allow python plugins to be reloaded in a GUI. PY: Add infrastructure to allow python plugins to be reloaded in a GUI. Apr 22, 2024
@imikejackson imikejackson enabled auto-merge (squash) April 22, 2024 13:21
@imikejackson imikejackson force-pushed the feature/python_reload branch from 02b7fa6 to 57d4d84 Compare April 22, 2024 13:22
JDuffeyBQ and others added 9 commits April 22, 2024 09:23
@JDuffeyBQ @imikejackson
Added unloading python plugins API for GUI
8747c40 
Signed-off-by: Jared Duffey <[email protected]>
@JDuffeyBQ @imikejackson
Added PlaceholderFilter
7084063 
Signed-off-by: Jared Duffey <[email protected]>
@JDuffeyBQ @imikejackson
Added try except blocks around each filter import in ExamplePlugin
ca87703 
* If one filter has a syntax error it now does not prevent the rest
of the plugin from loading. Most useful for plugin development

Signed-off-by: Jared Duffey <[email protected]>
@JDuffeyBQ @imikejackson
Added PlaceholderFilter test
cfd3fea 
Signed-off-by: Jared Duffey <[email protected]>
@JDuffeyBQ @imikejackson
Added ManualImportFinder for dynamic imports from embedded python
11a8975 
* Implements importlib.abc.MetaPathFinder
* Allows import statements to find the specified python modules
regardless of the values of sys.path

Signed-off-by: Jared Duffey <[email protected]>
@imikejackson
Fix generation of Python Plugins and filters to adhere to latest temp…
f33023b 
…lates

Signed-off-by: Michael Jackson <[email protected]>
@imikejackson
DOC: Update the documentation for nx.Pipeline
cf2056d 
Signed-off-by: Michael Jackson <[email protected]>
@imikejackson
DOC: adjust how we generate the Sphinx .rst files
60fa81f 
Signed-off-by: Michael Jackson <[email protected]>
@imikejackson
Clang format
90d82e2 
Signed-off-by: Michael Jackson <[email protected]>
JDuffeyBQ and others added 12 commits April 22, 2024 09:23
@JDuffeyBQ @imikejackson
Simplified findSpec function
68ddd9a 
Signed-off-by: Jared Duffey <[email protected]>
@JDuffeyBQ @imikejackson
Moved python embedding code to common header only library
d0e8834 
Signed-off-by: Jared Duffey <[email protected]>
@imikejackson
ENH: Add DataStructure.exists() to the python bindings
01978bf 
Signed-off-by: Michael Jackson <[email protected]>
@imikejackson
ENH: Expose getShape, getNumTuples from AttributeMatrix
7b8afcf 
Signed-off-by: Michael Jackson <[email protected]>
@imikejackson
ENH: add a 'human_name' and 'name' convenience functions to PipelineF…
7451d7a 
…ilter.

Signed-off-by: Michael Jackson <[email protected]>
@jmarquisbq @imikejackson
Change Example filter 1 input file parameter to not accept all extens…
b0f9f53 
…ions
@JDuffeyBQ @imikejackson
Added additional constructor for IFilter::PreflightValue binding
5416815 
Signed-off-by: Jared Duffey <[email protected]>
@JDuffeyBQ @imikejackson
Added bindings for IFilter::ProgressMessage
fb6a474 
Signed-off-by: Jared Duffey <[email protected]>
@JDuffeyBQ @imikejackson
Added __contains__ to DataStructure bindings
7071adb 
* Simplified `exists()` to use DataStructure::containsData
* Added explicit names to python args

Signed-off-by: Jared Duffey <[email protected]>
@JDuffeyBQ @imikejackson
Changed AttributeMatrix tuple_shape to a readonly attribute
ed09ba7 
* Removed AttributeMatrix __len__ since it conflicts with BaseGroup
* Removed binding for base group with no function name

Signed-off-by: Jared Duffey <[email protected]>
@JDuffeyBQ @imikejackson
Added nullptr check to PipelineFilter name and human_name
ce6f244 
Signed-off-by: Jared Duffey <[email protected]>
@JDuffeyBQ @imikejackson
Added example usage of PreflightValue to ExampleFilter1
84d7d7f 
Signed-off-by: Jared Duffey <[email protected]>
@imikejackson imikejackson force-pushed the feature/python_reload branch from 57d4d84 to 84d7d7f Compare April 22, 2024 13:23
@imikejackson imikejackson disabled auto-merge April 22, 2024 13:23
@imikejackson imikejackson merged commit 664f9f2 into develop Apr 22, 2024
8 checks passed
@imikejackson imikejackson deleted the feature/python_reload branch April 22, 2024 13:23
imikejackson added a commit that referenced this pull request Apr 22, 2024
@JDuffeyBQ @imikejackson @jmarquisbq
PY: Add infrastructure to allow python plugins to be reloaded in a GU…
6bf96d9 
…I. (#910)

Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Co-authored-by: Michael Jackson <[email protected]>
Co-authored-by: Jessica Marquis <[email protected]>
imikejackson added a commit that referenced this pull request Apr 22, 2024
@JDuffeyBQ @imikejackson @jmarquisbq
PY: Add infrastructure to allow python plugins to be reloaded in a GU…
67a7875 
…I. (#910)

Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Co-authored-by: Michael Jackson <[email protected]>
Co-authored-by: Jessica Marquis <[email protected]>
imikejackson added a commit that referenced this pull request Apr 22, 2024
@JDuffeyBQ @imikejackson @jmarquisbq
PY: Add infrastructure to allow python plugins to be reloaded in a GU…
12c9140 
…I. (#910)

Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Co-authored-by: Michael Jackson <[email protected]>
Co-authored-by: Jessica Marquis <[email protected]>
imikejackson added a commit to imikejackson/simplnx that referenced this pull request Oct 20, 2024
@JDuffeyBQ @imikejackson @jmarquisbq
PY: Add infrastructure to allow python plugins to be reloaded in a GU…
dc10b42 
…I. (BlueQuartzSoftware#910)

Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Co-authored-by: Michael Jackson <[email protected]>
Co-authored-by: Jessica Marquis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@imikejackson imikejackson imikejackson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JDuffeyBQ @imikejackson @jmarquisbq