-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: RenameAction and Filter Add Overwrite Option #912
Merged
nyoungbq
merged 9 commits into
BlueQuartzSoftware:develop
from
nyoungbq:enh/rename_overwrite_option
May 2, 2024
Merged
ENH: RenameAction and Filter Add Overwrite Option #912
nyoungbq
merged 9 commits into
BlueQuartzSoftware:develop
from
nyoungbq:enh/rename_overwrite_option
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyoungbq
changed the title
ENH: RenameAction and Filter now has overwrite option
ENH: RenameAction and Filter Add Overwrite Option
Apr 12, 2024
imikejackson
force-pushed
the
develop
branch
2 times, most recently
from
April 22, 2024 14:34
67a7875
to
12c9140
Compare
nyoungbq
force-pushed
the
enh/rename_overwrite_option
branch
2 times, most recently
from
April 30, 2024 16:38
2d41d26
to
6384ad7
Compare
mmarineBlueQuartz
requested changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just have some minor things to tweak for readability around changes that did not seem to make it into the PR.
...lugins/ITKImageProcessing/src/ITKImageProcessing/Filters/Algorithms/ITKImportFijiMontage.cpp
Outdated
Show resolved
Hide resolved
mmarineBlueQuartz
approved these changes
May 1, 2024
these were reverted changes that got missed after the renaming rebase Co-authored-by: Matthew Marine <[email protected]>
nyoungbq
force-pushed
the
enh/rename_overwrite_option
branch
from
May 1, 2024 19:39
0ecdb4c
to
1d2fe16
Compare
imikejackson
pushed a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
…ueQuartzSoftware#912) Co-authored-by: Matthew Marine <[email protected]> Added new overwrite functionality Works by just deleting other object and renaming accordingly (no move semantics) Small change in MergeResults()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new overwrite functionality
Works by just deleting other object and renaming accordingly (no move semantics)
Naming Conventions
Naming of variables should descriptive where needed. Loop Control Variables can use
i
if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the filesimplnx/docs/Code_Style_Guide.md
for a more in depth explanation.Filter Checklist
The help file
simplnx/docs/Porting_Filters.md
has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.Unit Testing
The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:
Code Cleanup