BUG: Fix HDF5 implicit copy crashes. #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed some noexcept specifiers * Fixed some override specifiers * Made some empty constructors default Signed-off-by: Jared Duffey <[email protected]>
* Moved support functions into anonymous namespace Signed-off-by: Jared Duffey <[email protected]>
imikejackson
changed the title
imikejackson
requested changes
Apr 23, 2024
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
|
The CI and my machine only found one warning in |
imikejackson
approved these changes
Apr 23, 2024
imikejackson
pushed a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
Signed-off-by: Jared Duffey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some HDF5 classes didn't get the changes meant to fix #916. This PR fixes those ones and adds a unit test.