PYTHON: Add helper methods to be able to easily create all the geometries. #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We talked about the API returning a Result<> object. |
They all return Result objects. |
joeykleingers
force-pushed
the
topic/Py_CreateGeometryHelperMethods
branch
2 times, most recently
from
d7abb61 to
a6591a1
Compare
imikejackson
approved these changes
Jun 3, 2024
|
Were we going to merge the various |
|
@JDuffeyBQ Those changes should be on #983 |
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
|
Ah then that enum should be bound using |
imikejackson
force-pushed
the
topic/Py_CreateGeometryHelperMethods
branch
from
a6591a1 to
4913a7c
Compare
JDuffeyBQ
requested changes
Jun 3, 2024
…pe.hpp. Signed-off-by: Joey Kleingers <[email protected]>
|
This is ready for review again. |
Signed-off-by: Joey Kleingers <[email protected]>
imikejackson
approved these changes
Jun 4, 2024
imikejackson
pushed a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
…ries. (BlueQuartzSoftware#981) Signed-off-by: Joey Kleingers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following helper methods to be able to easily create all the geometries:
nx.CreateGeometry.create_image_geometry
nx.CreateGeometry.create_rect_grid_geometry
nx.CreateGeometry.create_vertex_geometry
nx.CreateGeometry.create_edge_geometry
nx.CreateGeometry.create_triangle_geometry
nx.CreateGeometry.create_quad_geometry
nx.CreateGeometry.create_tetrahedral_geometry
nx.CreateGeometry.create_hexahedral_geometry
Also adds parameter names to the ChoicesParameter binding.