-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FILTER : SliceTriangleGeometry & CreateAMScanPaths #984
Merged
imikejackson
merged 27 commits into
BlueQuartzSoftware:develop
from
jmarquisbq:topic/create_scan_vectors
Jun 27, 2024
Merged
FILTER : SliceTriangleGeometry & CreateAMScanPaths #984
imikejackson
merged 27 commits into
BlueQuartzSoftware:develop
from
jmarquisbq:topic/create_scan_vectors
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imikejackson
force-pushed
the
topic/create_scan_vectors
branch
from
June 3, 2024 13:20
566b83e
to
0137fd3
Compare
mmarineBlueQuartz
approved these changes
Jun 4, 2024
jmarquisbq
force-pushed
the
topic/create_scan_vectors
branch
2 times, most recently
from
June 10, 2024 13:28
dac0d8e
to
d2b2944
Compare
jmarquisbq
force-pushed
the
topic/create_scan_vectors
branch
from
June 14, 2024 12:46
8dbabe7
to
f02eb4e
Compare
imikejackson
force-pushed
the
topic/create_scan_vectors
branch
from
June 20, 2024 15:10
f02eb4e
to
d242238
Compare
This was referenced Jun 20, 2024
imikejackson
force-pushed
the
topic/create_scan_vectors
branch
4 times, most recently
from
June 24, 2024 13:40
618e785
to
744dc32
Compare
imikejackson
force-pushed
the
topic/create_scan_vectors
branch
2 times, most recently
from
June 26, 2024 17:54
60f5101
to
3e08e5d
Compare
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
… filter" This reverts commit f1410b9.
…ences. Signed-off-by: Michael Jackson <[email protected]>
…be used. Signed-off-by: Michael Jackson <[email protected]>
…dEdges [NOTE: this is part of a bigger systemic issue that will be fixed on another branch but is needed here for unit tests to pass]
Signed-off-by: Michael Jackson <[email protected]>
imikejackson
force-pushed
the
topic/create_scan_vectors
branch
from
June 26, 2024 19:41
3e08e5d
to
fe467cf
Compare
Signed-off-by: Michael Jackson <[email protected]>
imikejackson
approved these changes
Jun 27, 2024
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
…e#984) Signed-off-by: Michael Jackson <[email protected]> Co-authored-by: Michael Jackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming Conventions
Naming of variables should descriptive where needed. Loop Control Variables can use
i
if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the filesimplnx/docs/Code_Style_Guide.md
for a more in depth explanation.Filter Checklist
The help file
simplnx/docs/Porting_Filters.md
has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.Unit Testing
The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:
Code Cleanup