Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow discovery and loading of pip installed python plugins #985

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

JDuffeyBQ
Copy link
Collaborator

  • Now load python plugins from installed pip environment
  • Packages must have "simplnx.plugins" entrypoint
  • Must have top level "get_plugin" function that returns a valid plugin object
  • Now check the result of addPlugin() call when loading python plugin to prevent duplicate plugins
  • Added dist/ to .gitnore to prevent python build files from being committed
  • Added pyproject.toml and meta.yaml to the python plugins as templates

JDuffeyBQ added 4 commits May 31, 2024 14:29
- Packages must have "simplnx.plugins" entrypoint
- Must have top level "get_plugin" function that returns a valid
plugin object

Signed-off-by: Jared Duffey <[email protected]>
- Prevents duplicate plugins from being loaded

Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
* Restructured plugin project layout

Signed-off-by: Jared Duffey <[email protected]>
@JDuffeyBQ JDuffeyBQ requested a review from imikejackson May 31, 2024 20:39
@JDuffeyBQ JDuffeyBQ marked this pull request as ready for review May 31, 2024 20:39
@imikejackson imikejackson merged commit b33bc87 into develop Jun 3, 2024
8 checks passed
@imikejackson imikejackson deleted the feature/installed_python_plugins branch June 3, 2024 13:13
imikejackson pushed a commit to imikejackson/simplnx that referenced this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants