-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FILTER/ENH: DBSCAN Filter and Clustering Cleanup #994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyoungbq
force-pushed
the
filter/dbscan
branch
2 times, most recently
from
June 20, 2024 22:39
62e97dc
to
568ffd9
Compare
imikejackson
force-pushed
the
filter/dbscan
branch
from
June 21, 2024 00:28
568ffd9
to
7f5f7ad
Compare
…er clustering algorithms
…igher up in the docs Signed-off-by: Michael Jackson <[email protected]>
imikejackson
approved these changes
Jun 21, 2024
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
) Added: - DBSCAN Filter and algorithm - Ability to run a Memory or Time efficient versions of the algorithm - Added ability to randomly initialize to be more in line with traditional algorithm - Added 4 basic tests for different logic tests - Updated documentation - Renamed KUtilities to ClusteringUtilities to be more inline with true function - More Documentation (with images) - 1 more complex test case Signed-off-by: Michael Jackson <[email protected]> Co-authored-by: Michael Jackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
In progress:
Potential Future additions:
Naming Conventions
Naming of variables should descriptive where needed. Loop Control Variables can use
i
if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the filesimplnx/docs/Code_Style_Guide.md
for a more in depth explanation.Filter Checklist
The help file
simplnx/docs/Porting_Filters.md
has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.Unit Testing
The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:
Code Cleanup