[BUG] RTTTL pause does not work

[baxerus]

Bug report

Describe the bug

When you use a RTTTL sound with one (or multiple) pause (p) in it, there is no silence when the pause sign is played, but instead the last tone is played longer for the length of the pause

Additional information

• Devices involved:
  • Model: Ulanzi Awtrix Smart Pixel Clock 2882 (TC001)
  • awtrix3 version: v0.96

To Reproduce

Steps to reproduce the behavior:

Send a notification via MQTT (I only tried it via MQTT) to the Awtrix with the the following in it:
"rtttl": "s:d=4,o=5,b=250:d,p,p,p,p,p,p,p,f" .

Compare the output played by the Awtrix with what https://adamonsoon.github.io/rtttl-play/ and https://corax89.github.io/esp8266Game/soundEditor.html plays for this wonderful example s:d=4,o=5,b=250:d,p,p,p,p,p,p,p,f.

Expected behavior

When there is a pause (p), no tone is played.

[Blueforcer]

Jup, no fix found yet. Sorry

[baxerus]

Yet?

Between my bug report and your message are around 4 minutes 😃

[Blueforcer]

I know this problem for a while. Buts a external library and I don't understand where the problem is.

[baxerus]

My C++ skills are bad.
I glanced through the code here on github a bit. But I didn't even find out, where the noTone() function is defined (until there everything at least looked okay 😉)

[baxerus]

Also looked a bit through the code of the library.
This is the first occurrence of noTone() I could find...

In general the string noTone is only two times in the code.

My assumption is, it was never implemented and was simply forgotten 😃
If this is even possible without the code crashing (here my C++ knowledge about error handling or not handling is not enough)...

[eku]

What do you think about reporting the matter to the author of the library?

[baxerus]

No activity in the last 2 years on the library... Seems like an orphaned project 😞.

I created an issue anyway:
fabianoriccardi/melody-player#8