Move require statements to the beginning #6

Kinrany · 2019-03-27T23:46:48Z

Move all the require statements that don't have to be dynamic to the beginning of the files

client/index.js

lib/server.js

Kinrany · 2019-03-27T23:57:42Z

Wait, client/lib/lighting.js depends on client/index.js, so that'll probably break something.

monster860 · 2019-03-28T00:06:07Z

yeah that too

Kinrany · 2019-03-28T00:23:27Z

I checked the cyclic dependencies with madge, there shouldn't be any now. Well, other than those fixed by do_resolve.

Kinrany · 2019-03-28T00:24:47Z

Ahh, no, just using mob/index.js won't work because everything is imported as mob.js, not just mob :s

lib/atom/mob/index.js

Kinrany · 2019-03-28T09:57:56Z

Should work now. How do you test this stuff?

Move require statements to the beginning

85f1f07

monster860 requested changes Mar 27, 2019

View reviewed changes

client/index.js Outdated Show resolved Hide resolved

lib/server.js Outdated Show resolved Hide resolved

Kinrany added 4 commits March 28, 2019 03:18

Fix cyclic dependency in client/lib/lighting.js

1df4634

Move mob symbols to a separate module

272df39

Fix cyclic dependencies in lib/atom/lighting.js

c4434a5

Rename imported modules to avoid confusion

e55c895

Fix mob imports

5022b01

monster860 requested changes Mar 28, 2019

View reviewed changes

lib/atom/mob/index.js Outdated Show resolved Hide resolved

Kinrany added 2 commits March 28, 2019 03:52

Simplify symbols import in lib/atom/mob/index.js

ddba246

Remove one more line

2f2f7a8

Fix relative references in lib/atom/mob/index.js

ae611d2

Provide feedback