chore: build logger strings lazily (#106)

BobTheBuidler · Nov 2, 2024 · 5ce8d88 · 5ce8d88
1 parent 55e35f1
commit 5ce8d88
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/eth_portfolio/_decorators.py b/eth_portfolio/_decorators.py
@@ -26,21 +26,21 @@ def set_end_block_if_none(func: Callable[Concatenate[_I, Block, Block, _P], _T])
         async def wrap(obj: _I, start_block: Block, end_block: Optional[Block], *args: _P.args, **kwargs: _P.kwargs) -> _T:
             if end_block is None:
                 end_block = await get_buffered_chain_height()
-                logger.debug(f"end_block not provided, using {end_block}")
+                logger.debug("end_block not provided, using %s", end_block)
             async for thing in func(obj, start_block, end_block, *args, **kwargs):
                 yield thing
     elif asyncio.iscoroutinefunction(func):
         @functools.wraps(func)
         async def wrap(obj: _I, start_block: Block, end_block: Block, *args: _P.args, **kwargs: _P.kwargs) -> _T:
             if end_block is None:
                 end_block = await get_buffered_chain_height()
-                logger.debug(f"end_block not provided, using {end_block}")
+                logger.debug("end_block not provided, using %s", end_block)
             return await func(obj, start_block, end_block, *args, **kwargs)
     else:
         @functools.wraps(func)
         def wrap(obj: _I, start_block: Block, end_block: Block, *args: _P.args, **kwargs: _P.kwargs) -> _T:
             if end_block is None:
                 end_block = chain.height - _config.REORG_BUFFER
-                logger.debug(f"end_block not provided, using {end_block}")
+                logger.debug("end_block not provided, using %s", end_block)
             return func(obj, start_block, end_block, *args, **kwargs)
     return wrap
diff --git a/eth_portfolio/buckets.py b/eth_portfolio/buckets.py
@@ -63,7 +63,7 @@ async def _unwrap_token(token) -> str:
     return token
 
 def _pool_bucket(pool_tokens: set) -> Optional[str]:
-    logger.debug(f'Pool tokens: {pool_tokens}')
+    logger.debug('Pool tokens: %s', pool_tokens)
     if pool_tokens < BTC_LIKE:
         return list(BTC_LIKE)[0]
     if pool_tokens < ETH_LIKE:

diff --git a/eth_portfolio/portfolio.py b/eth_portfolio/portfolio.py
@@ -356,7 +356,7 @@ async def imported_func(self: Portfolio, *args: Any, **kwargs: Any) -> _argspec.
         """
         return await a_sync.gather({address: func(address, *args, **kwargs, sync=False) for address in self})
     setattr(Portfolio, func_name, imported_func)
-    logger.debug(f"Ported {func_name} from PortfolioAddress to Portfolio")
+    logger.debug("Ported %s from PortfolioAddress to Portfolio", func_name)
 
 
 def _get_missing_cols_from_KeyError(e: KeyError) -> List[str]: