Made order of properties in EventSerializers stable by sorting them b…

…y name.
Bobris · Jun 10, 2018 · 86b5d31 · 86b5d31
1 parent 8822bef
commit 86b5d31
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/BTDB/EventStoreLayer/ObjectTypeDescriptor.cs b/BTDB/EventStoreLayer/ObjectTypeDescriptor.cs
@@ -93,6 +93,7 @@ public bool FinishBuildFromType(ITypeDescriptorFactory factory)
                     _fields.Add(new KeyValuePair<string, ITypeDescriptor>(GetPersitentName(propertyInfo), descriptor));
                 }
             }
+            _fields.Sort((l, r) => string.Compare(l.Key, r.Key));
             return true;
         }
 

diff --git a/BTDBTest/TypeSerializersTest.ComplexDescribe.approved.txt b/BTDBTest/TypeSerializersTest.ComplexDescribe.approved.txt
@@ -2,8 +2,8 @@
 List<String>
 BTDBTest.TypeSerializersTest+SimpleDto
 {
-    StringField : String
     IntField : VInt32
+    StringField : String
 }
 BTDBTest.TypeSerializersTest+ClassWithList
 {
@@ -15,25 +15,25 @@ BTDBTest.TypeSerializersTest+ClassWithDict
 }
 BTDBTest.TypeSerializersTest+SelfPointing1
 {
+    Other1 : VInt32
     Self1 : BTDBTest.TypeSerializersTest+SelfPointing1
     Self2 : BTDBTest.TypeSerializersTest+SelfPointing2
     {
+        Other2 : String
         Self1 : BTDBTest.TypeSerializersTest+SelfPointing1
         Self2 : BTDBTest.TypeSerializersTest+SelfPointing2
-        Other2 : String
     }
-    Other1 : VInt32
 }
 BTDBTest.TypeSerializersTest+SelfPointing2
 {
+    Other2 : String
     Self1 : BTDBTest.TypeSerializersTest+SelfPointing1
     {
+        Other1 : VInt32
         Self1 : BTDBTest.TypeSerializersTest+SelfPointing1
         Self2 : BTDBTest.TypeSerializersTest+SelfPointing2
-        Other1 : VInt32
     }
     Self2 : BTDBTest.TypeSerializersTest+SelfPointing2
-    Other2 : String
 }
 BTDBTest.TypeSerializersTest+TestEnum
 enum {

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## [unreleased]
 
+### Fixed
+
+Made order of properties in EventSerializers stable by sorting them by name.
+
 ## 14.2.1
 
 ### Fixed
-Original file line number
+Diff line change
@@ Expand Up @@
                         _fields.Add(new KeyValuePair<string, ITypeDescriptor>(GetPersitentName(propertyInfo), descriptor));
                     }
                 }
+                _fields.Sort((l, r) => string.Compare(l.Key, r.Key));
                 return true;
             }
@@ Expand Down @@