Move disqus_shortname fallback logic into accessor block #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an issue where I couldn't use the
disqus_shortname
attribute I set inconfig/initializers/blogit.rb
this seemed to be because of the setter inlib/blogit/configuration.rb
, which seems to be concerned with the fallback and firing the warning if it's set withoutinclude_comments
being set to:disqus
.That method sets an instance variable in Blogit::Configuration though, which didn't work with the default comments view. By moving that logic from the setter into the accessor block, all I had to do was set my
:disqus_shortname
in the initializer and everything works automagically!